-
Notifications
You must be signed in to change notification settings - Fork 109
🐛 Allow to use image overrides from mounted custerctl-config.yaml file #616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Allow to use image overrides from mounted custerctl-config.yaml file #616
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Danil-Grigorev <[email protected]>
00155bf to
c40d35f
Compare
alexander-demicev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexander-demicev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Danil-Grigorev <[email protected]>
4bf526c to
1a099d6
Compare
furkatgofurov7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
LGTM label has been added. Git tree hash: 1bc434664c8fa4820c80450eec52dcb0c481e81b
|
What this PR does / why we need it:
This change allows to use mounted
clusterctl-config.yamlfile to override provider images.results in:
image: http://myorg.io/local-repo/cluster-api-provider-rke2-controlplane:v9.9.9and
image: http://myorg.io/local-repo/cluster-api-provider-rke2-bootstrap:v9.8.9for
rke2CP and Bootstrap providers.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #